open-mmlab / mmcv

OpenMMLab Computer Vision Foundation
https://mmcv.readthedocs.io/en/latest/
Apache License 2.0
5.91k stars 1.65k forks source link

[ROCM] Change the block size to 1024 during compilation. #2942

Open xiabo123 opened 1 year ago

xiabo123 commented 1 year ago

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The default block size of rocm is 256.The designed kenel has a block size of 512.May cause calculation errors. Set the maximum block size to 1024 during compilation.

Modification

The default block size of rocm is 256.The designed kenel has a block size of 512.May cause calculation errors. Set the maximum block size to 1024 during compilation.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

After PR: