search

open-policy-agent / conftest

Write tests against structured configuration data using the Open Policy Agent Rego query language
https://conftest.dev
Other
2.88k stars 307 forks source link

fix: make sure lookup_ip_addr throwing builtin-err in test #1017

Closed boranx closed 1 week ago

boranx commented 2 weeks ago

It looks like non-existent domains are no longer causing built-in-err for lookup_ip_addr, except the parse-related issues. This PR makes sure lookup_ip_addr used in tests throws a parse error which causes builtin-err

It seems there's a regression on our test when the underlying name-resolution libs behavior changed after an opa/golang version update: https://github.com/open-policy-agent/opa/blob/main/docs/content/policy-reference.md#notes-on-name-resolution-netlookup_ip_addr

Addresses CI errors on: #1016 #1015 #1009 #1008

boranx commented 1 week ago

I'll go ahead and fix the test for lookup_ip_addr to fix CI for now We can re-evaluate the test in another PR