Do not deserialize admission request object more than once - Githubissues

open-policy-agent / gatekeeper

🐊 Gatekeeper - Policy Controller for Kubernetes

https://open-policy-agent.github.io/gatekeeper/

Apache License 2.0

3.72k stars 764 forks source link

Do not deserialize admission request object more than once #2195

Open davis-haba opened 2 years ago

davis-haba commented 2 years ago

With the new Expansion feature in https://github.com/open-policy-agent/gatekeeper/pull/2062, we are deserializing the request object in the validation webhook twice:

once when we expand the object (new code)
again when we actually match the object (existing code)

We should somehow pass the deserialized object down the chain such that it does not have to be deserialized again when matched.

Original comment thread: https://github.com/open-policy-agent/gatekeeper/pull/2062#discussion_r930513806

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.