Closed David-Jaeyoon-Lee closed 2 weeks ago
Attention: Patch coverage is 50.74627%
with 33 lines
in your changes missing coverage. Please review.
Project coverage is 47.72%. Comparing base (
3350319
) to head (996608e
). Report is 192 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/gator/verify/runner.go | 59.64% | 16 Missing and 7 partials :warning: |
pkg/gator/reader/read_resources.go | 0.00% | 10 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (996608e). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (3350319) | HEAD (996608e) | |------|------|------| |unittests|2|1|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Are we going to add expannsionTemplate
to suite?
@David-Jaeyoon-Lee LGTM after gator tests are modified for expansion template, this might help adding those tests David-Jaeyoon-Lee#2.
I think I added similar tests in this pr already. Or am I misunderstanding something? What specifically do we want to modify?
Edit: Nevermind I see
@David-Jaeyoon-Lee you will probably need to update docs as well to let users know how to use this. This is probably the best place to include that information - https://open-policy-agent.github.io/gatekeeper/website/docs/gator#the-gator-verify-subcommand.
I am ok with a follow up PR to update the docs. @maxsmythe @ritazh @sozercan wdyt?
Thank you to all who were involved in making this happen!
What this PR does / why we need it: It allows for expansion in gator verify.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged): Fixes #3432Special notes for your reviewer: