Open JaydipGabani opened 1 day ago
Attention: Patch coverage is 62.50000%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 47.49%. Comparing base (
3350319
) to head (90d646c
). Report is 205 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
...onstrainttemplate/constrainttemplate_controller.go | 62.50% | 4 Missing and 2 partials :warning: |
:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (90d646c). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (3350319) | HEAD (90d646c) | |------|------|------| |unittests|2|1|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like this is still an issue:
ValidatingAdmissionPolicy 'gatekeeper-k8srequiredlabelsvap' with binding 'gatekeeper-all-must-have-label-scoped' denied request: failed to configure binding: paramKind kind
&ParamKind{APIVersion:constraints.gatekeeper.sh/v1beta1,Kind:K8sRequiredLabelsVap,}
not yet synced to use for admission
Yeah! I am working on resolving this.
What this PR does / why we need it: Since we are deleting VAPB when constraint is being deleted, this test should not be needed anymore.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged): Fixes #Special notes for your reviewer: