open-policy-agent / gatekeeper

🐊 Gatekeeper - Policy Controller for Kubernetes
https://open-policy-agent.github.io/gatekeeper/
Apache License 2.0
3.72k stars 765 forks source link

chore: removing wait of vapb deletion #3718

Open JaydipGabani opened 1 day ago

JaydipGabani commented 1 day ago

What this PR does / why we need it: Since we are deleting VAPB when constraint is being deleted, this test should not be needed anymore.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #

Special notes for your reviewer:

codecov-commenter commented 1 day ago

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (3350319) to head (90d646c). Report is 205 commits behind head on master.

Files with missing lines Patch % Lines
...onstrainttemplate/constrainttemplate_controller.go 62.50% 4 Missing and 2 partials :warning:

:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (90d646c). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (3350319) | HEAD (90d646c) | |------|------|------| |unittests|2|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3718 +/- ## ========================================== - Coverage 54.49% 47.49% -7.00% ========================================== Files 134 236 +102 Lines 12329 19923 +7594 ========================================== + Hits 6719 9463 +2744 - Misses 5116 9563 +4447 - Partials 494 897 +403 ``` | [Flag](https://app.codecov.io/gh/open-policy-agent/gatekeeper/pull/3718/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-policy-agent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-policy-agent/gatekeeper/pull/3718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-policy-agent) | `47.49% <62.50%> (-7.00%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-policy-agent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ritazh commented 1 day ago

Looks like this is still an issue:

ValidatingAdmissionPolicy 'gatekeeper-k8srequiredlabelsvap' with binding 'gatekeeper-all-must-have-label-scoped' denied request: failed to configure binding: paramKind kind &ParamKind{APIVersion:constraints.gatekeeper.sh/v1beta1,Kind:K8sRequiredLabelsVap,} not yet synced to use for admission

JaydipGabani commented 1 day ago

Yeah! I am working on resolving this.