search

open-policy-agent / setup-opa

Sets up Open Policy Agent CLI in your GitHub Actions workflow.
Apache License 2.0
45 stars 12 forks source link

drop notice? #4

Closed srenatus closed 2 years ago

srenatus commented 2 years ago

I've just noticed (haha) that core.notice (https://github.com/infracost/setup-opa/blob/master/src/index.ts#L131) causes a build annotation like this:

image

I think we'd better use those more sparingly, i.e. drop that line. What do you think?

alikhajeh1 commented 2 years ago

@srenatus I hadn't noticed that before either! Do you have a link to an example PR that shows this? I googled a bit for github annotations but couldn't find an example to see how it looks. I ask as we also use that line in https://github.com/infracost/actions/blob/master/setup/src/index.ts#L143

srenatus commented 2 years ago

https://github.com/open-policy-agent/opa/actions/runs/1691836944 Any recent OPA PR, really 😄 We've started using it there.

srenatus commented 2 years ago

It also looks like something's worrying here:

image

https://github.com/open-policy-agent/opa/pull/4221/checks

alikhajeh1 commented 2 years ago

Thanks! Yeah I think just logging the version in the console output is better than an annotation. @tim775 can you possibly do the same for the infracost/setup action?