search

open-psa / mef

The Open-PSA Model Exchange Format
https://open-psa.github.io/mef
5 stars 7 forks source link

Mention the way to define "pass-through" gates #43

Closed rakhimov closed 7 years ago

rakhimov commented 7 years ago

This piece is left implicit in the description of gates. A single event is allowed as a gate definition without any connective, which is interpreted as "pass-through", no-logic, null.

cfolleau commented 7 years ago

I think it is not implicit, when I have one child under my gate I handle it like that in the boolean formula:

Adding "pass-though" attribut would mean : topgate = myBasicEvent which is different.

I am not sure it is necessary to handle this simplification. We should add features is this exchange format only when it brings more useful things than before.

ghost commented 7 years ago

Agreed.

On 4/20/2017 18:09, Cyrille Folleau wrote:

I think it is not implicit, when I have one child under my gate I handle it like that in the boolean formula:

  • topgate = gateNumber2whith1child
  • gateNumber2whith1child = myBasicEvent Naturally it can be simplified when performing BDD computation (but not necessary since it doesn't change performance)

Adding "pass-though" attribut would mean : topgate = myBasicEvent which is different.

I am not sure it is necessary to handle this simplification. We should add features is this exchange format only when it brings more useful things than before.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/open-psa/mef/pull/43#issuecomment-295644566, or mute the thread https://github.com/notifications/unsubscribe-auth/AXHNM8nzUXFqERgpMFhn4nNjbSgU4YNWks5rxyDWgaJpZM4NBLI-.

rakhimov commented 7 years ago

@cfolleau Please go through the proposed changes again. This PR does not introduce anything new (no new attributes or elements or features). It only clarifies what is possible with the current MEF, which is a single argument gates.

Note this is about gates, not the formula. I had a user trying to use examples from the NASA handbook and wondering how to define 'a single arg gates' (existing just to add extra context and information). The MEF standard currently doesn't talk about it but allows it as you described. This clarification is meant for users.

rakhimov commented 7 years ago

@cfolleau Did you mean to merge?

cfolleau commented 7 years ago

Oups sorry, I clicked on the wrong button, Yes I want to merge.