Closed tranzystorekk closed 1 year ago
Oops, meant for this to be a draft for now.
Ping @wucke13 for discussion
Added requested changes, split the code into some more includedir related functions to allow early return if vendored
is enabled.
Added the suggested change and README docs. I was split between processing the patch version as an interger or as a str, but the latter seems more reliable, especially against versions like 0.8.001
Shoot, I hadn't thought about this but 001
being not allowed also means that #192 is again unsolved.
And that is a problem for releasing updates :(
I guess I also forgot something - an env var like LIBOQS_NO_VENDOR
that would make it easier for distributions to ensure we're only built if system package is available.
Such a thing makes it easier for distros to manage a central liboqs package with e.g. sexurity vulnerabilities patched, as with SSL libraries.
Sounds like a good addition
Addresses #190
Adds necessary changes to optionally detect the system liboqs version and link to it.
To consider:
vendor
feature, or can we defer topkg-config
crate's env var configuration (e.g. "LIBOQS_NO_PKG_CONFIG")0.8.0
&& <0.9.0
) enough?Tested this manually with a system-installed build of liboqs 0.8.0-rc1. Not sure how best to test this in CI yet.