Reduce code overlap - Githubissues

open-rmf / fleet_adapter_mir

RMF/RoMi-H fleet adapter for the MiR API

Apache License 2.0

15 stars 15 forks source link

Reduce code overlap #35

Closed xiyuoh closed 10 months ago

xiyuoh commented 1 year ago

This PR targets #34 and modifies the MiR FM fleet adapter to import common codes and methods from the MiR fleet adapter. It also updates the MiR fleet adapter to supports multi-map transformation by making the stored MiRCommandHandle transforms dictionary map-specific.

koonpeng commented 1 year ago

We no longer have a MiR robot so it is hard to test, code LGTM.

Yadunund commented 1 year ago

Since we have several users of this pkg we should aim to have these changes tested with a robot before merging.

xiyuoh commented 10 months ago

Closing as we are no longer actively supporting MiRFleet adapters