open-rmf / rmf_ros2

Internal ROS infrastructure for RMF
Apache License 2.0
74 stars 60 forks source link

WIP, uncrustify noble fixes #361

Closed luca-della-vedova closed 5 months ago

luca-della-vedova commented 5 months ago

Similar approach to https://github.com/open-rmf/rmf_task/pull/119

luca-della-vedova commented 5 months ago

It seems the two version of uncrustify have conflicing recommendations and not sure it is possible to satisfy both of them. For example in https://github.com/open-rmf/rmf_ros2/pull/361/commits/41d3a43857dc5a0ab266aa95f48cdf990bf21eeb this change is needed to make the linter happy in 24.04, however it makes the action under 22.04 fails. This is just one example but most of the recommended changes applied in the commit make 22.04 fail

luca-della-vedova commented 5 months ago

Superseded by #362