search

open-rmf / rmf_ros2

Internal ROS infrastructure for RMF
Apache License 2.0
74 stars 60 forks source link

Fix bug when using timestamps for dispatcher task IDs #366

Closed aaronchongth closed 5 months ago

aaronchongth commented 5 months ago

Bug fix

Fixed bug

Fixes https://github.com/open-rmf/rmf_ros2/issues/252. This issue only shows up when the dispatcher node is not running with sim time due to casting issues when the double gets larger.

To recreate the issue, set use_sim_time to false when launching the dispatcher node in https://github.com/open-rmf/rmf_demos/blob/main/rmf_demos/launch/common.launch.xml#L60

Fix applied

mxgrey commented 5 months ago

We should probably wait for approval from @Yadunund before merging so we don't disturb the release process that's going on.

Yadunund commented 5 months ago

Yep kindly hold for a day or two more. Shall update here.

luca-della-vedova commented 5 months ago

Yep kindly hold for a day or two more. Shall update here.

I think we should be OK right?