Possible data race in Planner when using interrupt_flag in Options - Githubissues

open-rmf / rmf_traffic

Traffic management libraries for RMF

Apache License 2.0

28 stars 26 forks source link

Possible data race in Planner when using interrupt_flag in Options #28

Closed aaronchongth closed 3 years ago

aaronchongth commented 3 years ago

Bug report

Required information:

Discovered in https://github.com/open-rmf/rmf_traffic/pull/20, tsan workflow.

Description of the bug

Data race might occur since a std::shared_ptr<const bool> is not atomic, when used for interrupts in multi-threaded scenarios.
Flagged in multi-threaded test, https://github.com/open-rmf/rmf_traffic/blob/main/rmf_traffic/test/unit/agv/test_Planner.cpp#L1898-L1923

Additional information

Verified by commenting out multi-threaded test, https://github.com/open-rmf/rmf_traffic/tree/ci/tsan-remove-data-race

aaronchongth commented 3 years ago

Suppressing for now