open-rmf / rmf_traffic

Traffic management libraries for RMF
Apache License 2.0
28 stars 26 forks source link

Print out detailed information instead of crashing when midpoints cannot be interpolated #71

Closed mxgrey closed 2 years ago

mxgrey commented 2 years ago

Somehow this exception has been triggered in a real-life use case, but the exact cause has not been pinned down. When this happens, we will simply remove the midpoint as a candidate. The user will receive less information about the plan, but all important information regarding the plan will still be provided.

codecov[bot] commented 2 years ago

Codecov Report

Merging #71 (4d95088) into main (3eabed7) will decrease coverage by 0.01%. The diff coverage is 6.89%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   22.64%   22.62%   -0.02%     
==========================================
  Files         364      364              
  Lines       29995    30015      +20     
  Branches    13811    13829      +18     
==========================================
  Hits         6792     6792              
- Misses      13918    13935      +17     
- Partials     9285     9288       +3     
Flag Coverage Δ
tests 22.62% <6.89%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._traffic/agv/planning/DifferentialDrivePlanner.cpp 43.38% <6.89%> (-1.11%) :arrow_down:
...mf_traffic/include/rmf_traffic/agv/Interpolate.hpp 0.00% <0.00%> (ø)