search

open-rmf / rmf_traffic

Traffic management libraries for RMF
Apache License 2.0
28 stars 26 forks source link

Add missing buildtool_depend on cmake #77

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

Bug fix

Fixed bug

These packages require cmake to build, but do not declare a dependency on the cmake tool.

Fix applied

The manifests have been updated to declare a buildtool dependency on cmake.

This should solve at least one of the problems preventing rmf_traffic_examples from building for RHEL on the RPM buildfarm: https://build.ros2.org/view/Rbin_rhel_el864/job/Rbin_rhel_el864__rmf_traffic_examples__rhel_8_x86_64__binary/

codecov[bot] commented 2 years ago

Codecov Report

Merging #77 (427e82d) into main (3e54804) will increase coverage by 0.20%. The diff coverage is n/a.

:exclamation: Current head 427e82d differs from pull request most recent head cef7a00. Consider uploading reports for the commit cef7a00 to get more accurate results

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   23.03%   23.23%   +0.20%     
==========================================
  Files         369      370       +1     
  Lines       30761    30741      -20     
  Branches    14366    14362       -4     
==========================================
+ Hits         7086     7143      +57     
+ Misses      14197    14108      -89     
- Partials     9478     9490      +12
Flag Coverage Δ
tests 23.10% <ø> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rmf_traffic/agv/planning/ShortestPathHeuristic.cpp 74.13% <0.00%> (-1.67%) :arrow_down:
rmf_traffic/src/rmf_traffic/agv/Planner.cpp 52.40% <0.00%> (-0.51%) :arrow_down:
rmf_traffic/include/rmf_traffic/Route.hpp 0.00% <0.00%> (ø)
rmf_traffic/src/rmf_traffic/DetectConflict.cpp 50.00% <0.00%> (ø)
rmf_traffic/src/rmf_traffic/schedule/Timeline.hpp 46.34% <0.00%> (ø)
rmf_traffic/src/rmf_traffic/agv/RouteValidator.cpp 49.57% <0.00%> (ø)
rmf_traffic/src/rmf_traffic/blockade/Moderator.cpp 44.82% <0.00%> (ø)
...mf_traffic/src/rmf_traffic/blockade/Constraint.cpp 35.00% <0.00%> (ø)
...f_traffic/src/rmf_traffic/agv/SimpleNegotiator.cpp 35.23% <0.00%> (ø)
...f_traffic/src/rmf_traffic/schedule/Negotiation.cpp 54.47% <0.00%> (ø)
... and 35 more
marcoag commented 2 years ago

@cottsay I believe we might be missing the gpg-sign on the commit here.