coderabbitai[bot]
commented
1 month ago [!CAUTION]
Review failed
The pull request is closed.
Walkthrough
The changes in the Parser class within the OpenSpaceToolkit::Astrodynamics::Validation namespace involve updates to the handling of celestial objects in the CreateEnvironment method. The celestials array's type has been modified from Array<Shared<Object>> to Array<Shared<const Object>>, promoting const-correctness. Consequently, the creation of celestial objects like Sun, Moon, and Earth has been adjusted to utilize shared pointers of the new const type. The overall structure and logic of the method remain unchanged.
Changes
| File Path | Change Summary |
|---|---|
| validation/OpenSpaceToolkit/Astrodynamics/Parser.cpp | - Updated variable type: Array<Shared<Object>> celestials → Array<Shared<const Object>> celestials - Updated method signature for Sun: celestials.add(std::make_shared<Sun>(Sun::Default())) → celestials.add(std::make_shared<const Sun>(Sun::Default())) - Updated method signature for Moon: celestials.add(std::make_shared<Moon>(Moon::Default())) → celestials.add(std::make_shared<const Moon>(Moon::Default())) - Updated method signature for Earth: celestials.add(std::make_shared<Earth>(Earth::FromModels(...))) → celestials.add(std::make_shared<const Earth>(Earth::FromModels(...))) |
Poem
In the realm of stars, so bright and vast,
Celestial friends, their types now cast.
With const in hand, they shine and gleam,
Immutable wonders, a dreamer's dream.
Oh, Parser's heart, in code we trust,
For safety and clarity, it's a must! 🌌✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
Summary by CodeRabbit
New Features
Bug Fixes