search

open-spaced-repetition / fsrs4anki-helper

An Anki add-on that supports Postpone & Advance & Load Balance & Easy Days & Disperse Siblings & Flatten
https://ankiweb.net/shared/info/759844606
MIT License
213 stars 17 forks source link

Fix/user should has one normal day at least when setting easy days #485

Closed Expertium closed 3 weeks ago

Expertium commented 3 weeks ago

I don't know if this works properly, and there is probably a more efficient way of doing it (with a single loop), but I absolutely will not let this go unfixed. LMSherlock, if you can do better than what I did in this PR - please do so.

L-M-Sherlock commented 3 weeks ago

What if the user has 6 reduced days and 1 minimum day? It's equal to 6 normal days and 1 minimum day. Should we warn the user in this case?

Expertium commented 3 weeks ago

Good question. I'd say yes. I think we should allow the user to do that, but display a warning "Your current configuration is equivalent to ..." 7 Reduced/Minimum days shouldn't be allowed at all.

L-M-Sherlock commented 3 weeks ago

So the condition is the user should have one normal day at least.

Expertium commented 3 weeks ago

The condition for not showing any warnings? Yes.

Expertium commented 3 weeks ago

Yeah, I think that's good. And please do this for the native implementation too, thank you.

L-M-Sherlock commented 3 weeks ago

The solution provided by sonnet doesn't work. I don't know how to implement it in Anki. The reactive frontend framework is confusing me. Please ask for other developer.