Feat/clear manual rescheduling logs

[L-M-Sherlock]

Preview:

Patch:

fsrs4anki-helper.ankiaddon.zip

[user1823]

Like https://github.com/open-spaced-repetition/fsrs4anki-helper/pull/455, this should force a one-way sync.

[L-M-Sherlock]

@user1823 nice catch. The last 90ed304 comment should solve it.

fsrs4anki-helper.ankiaddon.zip

[L-M-Sherlock]

@user1823 could you help me improve the wording?

[user1823]

Can you first explain what is the actual purpose of this feature? Is it aimed at removing just the "Reschedule cards on change" entries with the other entries being removed only because we can't keep them?

[L-M-Sherlock]

Yes, it aims at removing the useless entires generated by "Reschedule cards on change". In extreme case, the percentage of this kind of useless entires will reach 25%.

@Expertium, I hope you can elaborate it: https://discord.com/channels/368267295601983490/1282005522513530952/1304016208080666634

[user1823]

In Anki 24.11+, we can distinguish between Reschedule cards on change and Set due date entries (only those entries which were created after the update). However, if we still have to use the same SQL query because the older entries are ambiguous, I am wondering what was the benefit of that change.

[user1823]

Probably we need to make it more configurable. I am thinking something along these lines:

• In Anki 24.11+, this feature should, by default, only remove the entries with type = 5.
• The user can choose to remove the older entries with the warning that it will also remove Set Due Date entries and a message that they need to select this option only once (because the newer Reschedule on change entries can be removed with the default query).

@Expertium, WDYT? If you agree, can you help in designing the UI for this?

[Luc-Mcgrady]

What I've always thought would be a good solution for this would be to delete any manual review that comes directly before another manual review. That way the set due dates/reschedules that were never reviewed would be cleared while still leaving any reschedules/manual sets that actually matter.

Example:

[L-M-Sherlock]

What I've always thought would be a good solution for this would be to delete any manual review that comes directly before another manual review.

Could you help write the SQL? Or implement it in another way?

[Luc-Mcgrady]

DELETE FROM revlog as cur
WHERE cur.type >= 4
AND cur.factor <> 0
AND (
    SELECT type
    FROM revlog
    WHERE id = (
        SELECT min(id)
        FROM revlog
        WHERE id > cur.id
        AND cid == cur.cid
    )
) >= 4

This should work

[L-M-Sherlock]

Have a try:

fsrs4anki-helper.ankiaddon.zip

[L-M-Sherlock]

Done:

fsrs4anki-helper.ankiaddon.zip

[khonkhortisan]

Delete redundant manual revlog entries → force full sync? [yes] → remove revlog entries generated by "Set due date"? [no] → normal sync [y]. The yes/no dialogs should be in the other order, so that I'm locked into full syncing immediately after the full sync dialog.

[L-M-Sherlock]

Sorry, I'm confused. I think force full sync is necessary. If it's unnecessary, I have to rewrite the dialog of force full sync.

[user1823]

Yes, it is necessary.

But, move the full sync dialog AFTER you tell the user what this option does.

So, if not ask_one_way_sync(): return comes just before revlog_ids = mw.col.db.list(

[L-M-Sherlock]

cc

fsrs4anki-helper.ankiaddon.zip