open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.13k stars 2.4k forks source link

Migrate to latest semconv version and ensure we regularly update going forward #22095

Open mx-psi opened 1 year ago

mx-psi commented 1 year ago

Component(s)

No response

Describe the issue you're reporting

As highlighted by @sumo-drosiek on https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/18740#discussion_r1197999834, we use a lot of different versions of go.opentelemetry.io/collector/semconv across this repository.

We would want to:

For the latter, I am not sure what is the best way to do this; one option is to have an internal package that re-exports symbols from a fixed semconv package and just update this one. This package could be autogenerated to keep it updated.

github-actions[bot] commented 1 year ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 1 year ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

mx-psi commented 8 months ago

We can do this in two steps: first we update until 1.20.0, then we deal with the HTTP semantic conventions upgrade

narcis96 commented 2 months ago

Hello! I’m interested in taking on this issue as my first contribution to OpenTelemetry. I see it’s labeled as a 'good first issue,' and I’d love to get started. Please let me know your thoughts.

mx-psi commented 2 months ago

@narcis96 You can pick a component from the following list:

cmd/telemetrygen
connector/datadogconnector
connector/exceptionsconnector
connector/servicegraphconnector
connector/spanmetricsconnector
exporter/alertmanagerexporter
exporter/alibabacloudlogserviceexporter
exporter/awsemfexporter
exporter/awsxrayexporter
exporter/azuremonitorexporter
exporter/carbonexporter
exporter/clickhouseexporter
exporter/datadogexporter
exporter/instanaexporter
exporter/kafkaexporter
exporter/loadbalancingexporter
exporter/logzioexporter
exporter/mezmoexporter
exporter/pulsarexporter
exporter/sentryexporter
exporter/signalfxexporter
exporter/splunkhecexporter
exporter/tencentcloudlogserviceexporter
extension/opampextension
internal/coreinternal
internal/exp
internal/filter
internal/metadataproviders
internal/splunk
pkg/translator
processor/attributesprocessor
processor/k8sattributesprocessor
processor/probabilisticsamplerprocessor
processor/resourcedetectionprocessor
processor/spanprocessor
processor/sumologicprocessor
receiver/awsecscontainermetricsreceiver
receiver/awsfirehosereceiver
receiver/awsxrayreceiver
receiver/azureeventhubreceiver
receiver/datadogreceiver
receiver/dockerstatsreceiver
receiver/hostmetricsreceiver
receiver/jaegerreceiver
receiver/k8sclusterreceiver
receiver/k8seventsreceiver
receiver/k8sobjectsreceiver
receiver/kafkareceiver
receiver/kubeletstatsreceiver
receiver/prometheusreceiver
receiver/pulsarreceiver
receiver/receivercreator
receiver/sapmreceiver
receiver/skywalkingreceiver
receiver/splunkhecreceiver
receiver/zipkinreceiver
testbed/tests

and update all imports that refer to go.opentelemetry.io/collector/semconv with a version below v1.18.0 to the highest version you can. This would etiher be v1.18.0 or, in some other cases, v1.27.0. Please start with a single component so that the PR is small and we can give you quick feedback!

narcis96 commented 2 months ago

thanks ! will do that.