search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.94k stars 2.29k forks source link

prometheusremotewrite export unit as part of metadata #29452

Open jmichalek132 opened 10 months ago

jmichalek132 commented 10 months ago

Component(s)

exporter/prometheusremotewrite

Describe the issue you're reporting

As discussed here https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/27565#discussion_r1394570264 the current implementation of metadata in the remote write exporter leaves unit unset, because prometheus expects full words instead of the UCUM abbreviation. To enabling this refactoring of https://github.com/jmichalek132/opentelemetry-collector-contrib/blob/1f646ab1bf7f01e014cadbfff9494e3694cf9c18/pkg/translator/prometheus/normalize_name.go#L119 might be necessary.

I don't think this is critical, especially since as afar as I know there is no way to view the unit in the UI of prometheus or Grafana as of now. So it's mostly relevant for other systems using the prometheus metadata APIs which will return the unit if set.

github-actions[bot] commented 10 months ago

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

crobert-1 commented 10 months ago

Removed the needs triage label due to the discussion from the referenced PR.

Thanks for including the references in your issue description @jmichalek132!

jmichalek132 commented 10 months ago

Hey, @crobert-1 could we please remove the bug label too? Since this is not really a bug.

jmichalek132 commented 8 months ago

As far as I can tell Grafana currently doesn't show unit even when it's present in metadata, so I will hold off on implementing this until that changes. FIlled an issue on Grafana for this https://github.com/grafana/grafana/issues/80512

github-actions[bot] commented 6 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

jmichalek132 commented 6 months ago

Not stale I will get to this.

github-actions[bot] commented 4 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.