open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.95k stars 2.29k forks source link

[pkg/golden] Make errrors easier to work on #30795

Closed atoulme closed 1 day ago

atoulme commented 8 months ago

Component(s)

No response

Is your feature request related to a problem? Please describe.

If a resource doesn't match, we get:

missing expected resource: map[container.image.name:quay.io/splunko11ytest/java_test container.image.tag:latest deployment.environment:dev host.name:kind-control-plane k8s.cluster.name:dev-operator k8s.container.name:java-test k8s.namespace.name:default k8s.node.name:kind-control-plane k8s.pod.labels.app:java-test os.description:Linux 6.5.11-linuxkit os.type:linux process.command_args:[/opt/java/openjdk/bin/java -Djava.util.logging.config.file=/usr/local/tomcat/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djdk.tls.ephemeralDHKeySize=2048 -Dorg.apache.catalina.security.SecurityListener.UMASK=0027 --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED -classpath /usr/local/tomcat/bin/bootstrap.jar:/usr/local/tomcat/bin/tomcat-juli.jar -Dcatalina.base=/usr/local/tomcat -Dcatalina.home=/usr/local/tomcat -Djava.io.tmpdir=/usr/local/tomcat/temp org.apache.catalina.startup.Bootstrap start] process.executable.path:/opt/java/openjdk/bin/java process.runtime.description:Eclipse Adoptium OpenJDK 64-Bit Server VM 21.0.2+13-LTS process.runtime.name:OpenJDK Runtime Environment process.runtime.version:21.0.2+13-LTS service.name:java-test service.version:latest splunk.distro.version:1.30.0 splunk.zc.method:splunk-otel-java:v1.30.0 telemetry.auto.version:splunk-1.30.0-otel-1.32.0 telemetry.sdk.language:java telemetry.sdk.name:opentelemetry]
                             -  unexpected resource: map[container.image.name:quay.io/splunko11ytest/java_test container.image.tag:latest deployment.environment:dev host.name:kind-control-plane k8s.cluster.name:dev-operator k8s.container.name:java-test k8s.namespace.name:default k8s.node.name:kind-control-plane k8s.pod.labels.app:java-test os.description:Linux 6.2.0-1018-azure os.type:linux process.command_args:[/opt/java/openjdk/bin/java -Djava.util.logging.config.file=/usr/local/tomcat/conf/logging.properties -Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager -Djdk.tls.ephemeralDHKeySize=2048 -Dorg.apache.catalina.security.SecurityListener.UMASK=0027 --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED -classpath /usr/local/tomcat/bin/bootstrap.jar:/usr/local/tomcat/bin/tomcat-juli.jar -Dcatalina.base=/usr/local/tomcat -Dcatalina.home=/usr/local/tomcat -Djava.io.tmpdir=/usr/local/tomcat/temp org.apache.catalina.startup.Bootstrap start] process.executable.path:/opt/java/openjdk/bin/java process.runtime.description:Eclipse Adoptium OpenJDK 64-Bit Server VM 21.0.2+13-LTS process.runtime.name:OpenJDK Runtime Environment process.runtime.version:21.0.2+13-LTS service.name:java-test service.version:latest splunk.distro.version:1.30.0 splunk.zc.method:splunk-otel-java:v1.30.0 telemetry.auto.version:splunk-1.30.0-otel-1.32.0 telemetry.sdk.language:java telemetry.sdk.name:opentelemetry]

This is hard to read

Describe the solution you'd like

Can we get a yaml or json output of the resource contents instead so we can diff easily, or feed that into a program to do the diff for us? a YAML file is best to get a clear diff.

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 8 months ago

Pinging code owners for pkg/golden: @djaglowski @atoulme. See Adding Labels via Comments if you do not have permissions to add labels yourself.

crobert-1 commented 8 months ago

Removing needs triage, it makes sense to me and it was filed by a code owner.

github-actions[bot] commented 6 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 4 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 2 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 1 day ago

This issue has been closed as inactive because it has been stale for 120 days with no activity.