open-telemetry / opentelemetry-dotnet

The OpenTelemetry .NET Client
https://opentelemetry.io
Apache License 2.0
3.18k stars 753 forks source link

[api] Mark SetStatus & GetStatus ActivityExtensions obsolete #5781

Closed ysolomchenko closed 1 month ago

ysolomchenko commented 1 month ago

Fixes https://github.com/open-telemetry/opentelemetry-dotnet/issues/4755 Design discussion issue https://github.com/open-telemetry/opentelemetry-dotnet/discussions/4703

Changes

Mark SetStatus activity extensions method obsolete

Merge requirement checklist

vishweshbankwar commented 1 month ago

@ysolomchenko - Please take a look at test failures.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.35%. Comparing base (6250307) to head (1eb54ca). Report is 298 commits behind head on main.

Files Patch % Lines
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 84.61% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/graphs/tree.svg?width=650&height=150&src=pr&token=vscyfvPfy5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #5781 +/- ## ========================================== + Coverage 83.38% 86.35% +2.96% ========================================== Files 297 256 -41 Lines 12531 11146 -1385 ========================================== - Hits 10449 9625 -824 + Misses 2082 1521 -561 ``` | [Flag](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `?` | | | [unittests-Project-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.95% <85.71%> (?)` | | | [unittests-Project-Stable](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.27% <85.71%> (?)` | | | [unittests-Solution](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `86.27% <85.71%> (?)` | | | [unittests-UnstableCoreLibraries-Experimental](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | `85.67% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [src/OpenTelemetry.Api/Trace/TelemetrySpan.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FTrace%2FTelemetrySpan.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL1RyYWNlL1RlbGVtZXRyeVNwYW4uY3M=) | `88.40% <100.00%> (ø)` | | | [...penTelemetry/Trace/Processor/ExceptionProcessor.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781?src=pr&el=tree&filepath=src%2FOpenTelemetry%2FTrace%2FProcessor%2FExceptionProcessor.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkvVHJhY2UvUHJvY2Vzc29yL0V4Y2VwdGlvblByb2Nlc3Nvci5jcw==) | `100.00% <ø> (ø)` | | | [src/OpenTelemetry.Api/Trace/ActivityExtensions.cs](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781?src=pr&el=tree&filepath=src%2FOpenTelemetry.Api%2FTrace%2FActivityExtensions.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c3JjL09wZW5UZWxlbWV0cnkuQXBpL1RyYWNlL0FjdGl2aXR5RXh0ZW5zaW9ucy5jcw==) | `90.32% <84.61%> (-5.14%)` | :arrow_down: | ... and [208 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-dotnet/pull/5781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)