open-telemetry / opentelemetry-erlang-contrib

OpenTelemetry instrumentation for Erlang & Elixir
https://opentelemetry.io
Apache License 2.0
139 stars 109 forks source link

Adding opentelemetry_quantum + opentelemetry_heroku to this project #179

Open tomtaylor opened 1 year ago

tomtaylor commented 1 year ago

Hello, we've implemented two libraries for OpenTelemetry that we'd like to offer to this project.

Happy to keep maintaining these separately, but I'd love to see them maintained alongside the other libraries if that's useful.

tsloughter commented 1 year ago

Great! Would love to have them in here, and you can remain on as an approver for those particular libs in this repo.

The only issue is the Heroku one should be in Erlang. I think Otel Quantum is fine in Elixir since that is a library for Elixir. Happy to help, if you need it, with the conversion.

tomtaylor commented 1 year ago

Brilliant, thanks. I totally forgot the Heroku one should be in Erlang! My Erlang is a bit rusty, but I can give it a go on a branch and share to check I've got the right approach? It's a very simple library - shouldn't be hard to port over.

tsloughter commented 1 year ago

Sounds good :+1:

tomtaylor commented 1 year ago

Could you give this a look over when you get a moment? I've tried to reimplement it in Erlang, but my Erlang is very rusty!

tsloughter commented 1 year ago

Looks good! But need to update https://github.com/breakroom/opentelemetry_heroku/blob/main/rebar.config#L25