search

open-telemetry / opentelemetry-js-contrib

OpenTelemetry instrumentation for JavaScript modules
https://opentelemetry.io
Apache License 2.0
709 stars 529 forks source link

Upgrade ZoneJS to 0.15.0 to support latest Angular (v19) #2559

Open geemorin opened 3 days ago

geemorin commented 3 days ago

What version of OpenTelemetry are you using?

0.43.0

What version of Node are you using?

22.11.0

What did you do?

Migrated my project using auto-instrumentations-web@0.43.0 from Angular v18 to Angular v19

What did you expect to see?

My project to build with success

What did you see instead?

09:54:49  npm error code ERESOLVE
09:54:49  npm error ERESOLVE could not resolve
09:54:49  npm error
09:54:49  npm error While resolving: @opentelemetry/auto-instrumentations-web@0.43.0
09:54:49  npm error Found: zone.js@0.15.0
09:54:49  npm error node_modules/zone.js
09:54:49  npm error   zone.js@"^0.15.0" from the root project
09:54:49  npm error   peer zone.js@"~0.15.0" from @angular/core@19.0.1
09:54:49  npm error   node_modules/@angular/core
09:54:49  npm error     @angular/core@"^19.0.1" from the root project
09:54:49  npm error     peer @angular/core@"19.0.1" from @angular/animations@19.0.1
09:54:49  npm error     node_modules/@angular/animations
09:54:49  npm error       @angular/animations@"^19.0.1" from the root project
09:54:49  npm error       2 more (@angular/material, @angular/platform-browser)
09:54:49  npm error     18 more (@angular/cdk, @angular/common, @angular/compiler, ...)
09:54:49  npm error
09:54:49  npm error Could not resolve dependency:
09:54:49  npm error peer zone.js@"^0.11.4 || ^0.13.0 || ^0.14.0" from @opentelemetry/auto-instrumentations-web@0.43.0
09:54:49  npm error node_modules/@opentelemetry/auto-instrumentations-web
09:54:49  npm error   @opentelemetry/auto-instrumentations-web@"^0.43.0" from the root project
09:54:49  npm error
09:54:49  npm error Conflicting peer dependency: zone.js@0.14.10
09:54:49  npm error node_modules/zone.js
09:54:49  npm error   peer zone.js@"^0.11.4 || ^0.13.0 || ^0.14.0" from @opentelemetry/auto-instrumentations-web@0.43.0
09:54:49  npm error   node_modules/@opentelemetry/auto-instrumentations-web
09:54:49  npm error     @opentelemetry/auto-instrumentations-web@"^0.43.0" from the root project
09:54:49  npm error
09:54:49  npm error Fix the upstream dependency conflict, or retry
09:54:49  npm error this command with --force or --legacy-peer-deps
09:54:49  npm error to accept an incorrect (and potentially broken) dependency resolution.

Additional context

N/A

pichlermarc commented 3 days ago

We'll update this in the core repo and then we'll update it here as well. Marking this as a feature-request since we don't claim to support this version at the moment.

pichlermarc commented 3 days ago

Update: PR to update this package in the core repo: https://github.com/open-telemetry/opentelemetry-js/pull/5213/files - we'll need to address the rest of the packages here once we have published a release in the core repo.