open-telemetry / opentelemetry-specification

Specifications for OpenTelemetry
https://opentelemetry.io
Apache License 2.0
3.76k stars 890 forks source link

Minor fixes of typos in trace/{sdk,api}.md #4216

Closed yuanyuanzhao3 closed 2 months ago

yuanyuanzhao3 commented 2 months ago

Changes

Fixes a few typos in the specifications.

linux-foundation-easycla[bot] commented 2 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

reyang commented 2 months ago

Thanks @yuanyuanzhao3! Would you clear the CLA https://github.com/open-telemetry/opentelemetry-specification/pull/4216#issuecomment-2359846072?

yuanyuanzhao3 commented 2 months ago

Thanks @yuanyuanzhao3! Would you clear the CLA #4216 (comment)?

done.

yuanyuanzhao3 commented 2 months ago

can someone approve the workflow run? thanks.

yuanyuanzhao3 commented 2 months ago

I'm also not allowed to merge. I guess I'm too new. Please let me know if there anything I missed. Thanks.

cijothomas commented 2 months ago

I'm also not allowed to merge. I guess I'm too new. Please let me know if there anything I missed. Thanks.

No worries. Only maintainers of this repo can do the merging. Unless there are open conversations/request-for-changes, this is typically merged in couple days. This one is editorial, so likely much faster! https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#how-to-get-your-pr-merged

reyang commented 2 months ago

I'm also not allowed to merge. I guess I'm too new. Please let me know if there anything I missed. Thanks.

No worries. Only maintainers of this repo can do the merging. Unless there are open conversations/request-for-changes, this is typically merged in couple days. This one is editorial, so likely much faster! https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#how-to-get-your-pr-merged

Faster than your comment @cijothomas 😆

cijothomas commented 2 months ago

Concurrent, not parallel 😄

yuanyuanzhao3 commented 2 months ago

Thanks everyone. That marked my first PR in OTel. Small but it's a start.