search

open-traffic-generator / snappi-ixnetwork

The Keysight IxNetwork implementation of the open-traffic-generator models.
MIT License
17 stars 10 forks source link

Count of ECN packets from Stats instead of counting from packet capture #541

Open ANISH-GOTTAPU opened 2 years ago

ANISH-GOTTAPU commented 2 years ago

Is your feature request related to a use case? Please describe. As of now in the test https://github.com/Azure/sonic-mgmt/blob/master/tests/snappi/ecn/test_dequeue_ecn_with_snappi.py , the count of ECN packets is calculated by capturing the packets and check for ECN bit.

The test works for 100 packets, but for scaling i.e capturing millions of packets has it's own limitations. 1) Increase in process time. 2) Hardware Limitation of packet capture on cards.

Describe the solution you'd like A better way to calculate the count instead of capture (using custom stats filter).

alpeshspatel commented 2 years ago

Anish, Additionally, we need the ability to clear the counter

ANISH-GOTTAPU commented 2 years ago

@alpeshspatel : Clear counters is part of start transmit, if you start transmit on a flow the counters get reset and starts from 0 whereas clearing the counters during transmit is not available.

Can you explain the use case for clearing the counters during the transmit?

alpeshspatel commented 2 years ago

Anish - we should be ok if the counters are cleared on start of a flow.