search

open-wc / custom-elements-manifest

Custom Elements Manifest is a file format that describes custom elements in your project.
https://custom-elements-manifest.open-wc.org/
226 stars 37 forks source link

feature: ignore nested node modules #258

Open andrico1234 opened 1 month ago

andrico1234 commented 1 month ago

~Note: I added a test case to simulate the bad scenario, but it seems to work even with the old regex.~

The test case now fails using the old regex pattern, but the set up for the test is complex. I worry that it pollutes the top-level package.json file.

What do you think? Happy to remove the test if you feel it best

Resolves: https://github.com/open-wc/custom-elements-manifest/issues/256

netlify[bot] commented 1 month ago

Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
Latest commit 2defbc0d74c51dbd58c7c9de39921f8e36ce728e
Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/664f7110a722930008bbf13a
Deploy Preview https://deploy-preview-258--custom-elements-manifest-analyzer.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andrico1234 commented 4 weeks ago

Heya, just wanted to get your thoughts on this, whether there's anything you'd like me to clarify or change :)