search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 44 forks source link

remove unused Code #200

Closed georgkrause closed 6 years ago

georgkrause commented 6 years ago

By getting into the Code again I found some commented stuff, eg in genericmidi.cxx. I thought i had already an PR which removed this, but anyway... Current question is: Should we keep it? Should we remove it? When is he best point for the remove? Now or later?

I could file a PR

harryhaaren commented 6 years ago

Cleanup is always welcome. Please use small commits, perhaps one per file or logical grouping of files, this makes review easier.

georgkrause commented 6 years ago

With #218 there is a PR targeting this issue.