Set Tempo by typing number into dialog

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.

http://openavproductions.com/luppp

GNU General Public License v3.0

258 stars 44 forks source link

Set Tempo by typing number into dialog #206

Closed georgkrause closed 6 years ago

georgkrause commented 6 years ago

Right click on "Tap"-Button and type any number. Issues #198 Obiously numbers between 60 and 220 does not make any sense so i will introduce an check.

Feedback welcome.

georgkrause commented 6 years ago

@harryhaaren you are right, but as mentioned it wasnt ready at all, that you merged this isnt that good, try to type any number <60 or >220. this makes crazy things on the GUI...

Will file another PR with the test if the value is between 60 and 220.

harryhaaren commented 6 years ago

Sure, a patch to sanity check the value is welcome. Sorry if I merged to soon, -Harry

georgkrause commented 6 years ago

Well, i am happy you merged it, thought because of #197 you dont like my PRs ;) Gives me some motivation to move on.