Sanity check BPM input - Githubissues

georgkrause commented 6 years ago

I am preparing a sanity check for the BPM-Input right now.

Problem is: I dont want to introduce new magic numbers, so i thought it would be great to get the minimum and maximum from any variables. As far as i found out, the borders for the value is only given by the GUI (<60 and >220 crashs the display).

So some questions:

Is 60 and 220 randomly choosen or are these numbers sensefull? (Maybe change them?)
Should we limit the BPM on the engine side? Currently the engine seems to work with any values and only the Dialer for the BPM limits what is possible. Of course we could also limit the custom input the same way.
If we just limit the custom input it might be an good idea to define the values in one place and calculate the Dialer-Limits and the Custom Input Values fromt that. Where to save the limits? Its needed in gmastertrack, but this wouldn't make any sense from my point of view.

@harryhaaren would be happy about some input :)

georgkrause commented 6 years ago

For explanation for the magic numbers: As far as i can see in src/gmastertrack.cxx#L26 is defined what can be set as bpm by the Dialer, and the numbers are hardcoded. When i want to use the same numbers for the custom input and we want to change it sometime, there are several places to be changed and this isn't that good as far as i know. Do i overthink this?

georgkrause commented 6 years ago

done bei #209

openAVproductions / openAV-Luppp

Sanity check BPM input #207