Closed georgkrause closed 6 years ago
For explanation for the magic numbers: As far as i can see in src/gmastertrack.cxx#L26 is defined what can be set as bpm by the Dialer, and the numbers are hardcoded. When i want to use the same numbers for the custom input and we want to change it sometime, there are several places to be changed and this isn't that good as far as i know. Do i overthink this?
done bei #209
I am preparing a sanity check for the BPM-Input right now.
Problem is: I dont want to introduce new magic numbers, so i thought it would be great to get the minimum and maximum from any variables. As far as i found out, the borders for the value is only given by the GUI (<60 and >220 crashs the display).
So some questions:
@harryhaaren would be happy about some input :)