search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 44 forks source link

repair trackconfusion #222

Closed georgkrause closed 6 years ago

georgkrause commented 6 years ago

This PR adresses #220.

To explain: When we/someone built the stereo signal chain in luppp, the way to access buffers needed to change. Before stereo, we could simply do buffer[ first_track + current_track]. But since there are two Buffers for each track, eg Left and Right, we need to skip 2 buffers for each track. This PR changes all buffer reads to go this way: buffer[ first_track + current_track * 2]

We could also change the order of the buffers in buffers.hxx to track_1_l track_2_l ... track_1_r track_2_r

but this PR seems to be the better solution for me.

Thanks to @coderkun for the help.

Before we merge i would like to have some more tests from other users.

coderkun commented 6 years ago

I can confirm that these changes fix the track outputs. Good work, @georgkrause. Let me see if I can add some useful comments.

georgkrause commented 6 years ago

nice work. thanks @coderkun

georgkrause commented 6 years ago

Changed to please merge since we have two possitve test results. @harryhaaren when you get any problems while testing this for merging, please let me know.