search

openAVproductions / openAV-Luppp

Luppp is a live performance tool, created by OpenAV productions.
http://openavproductions.com/luppp
GNU General Public License v3.0
258 stars 44 forks source link

Fix Input Signal Flow #230

Closed georgkrause closed 6 years ago

georgkrause commented 6 years ago

This PR adresses #228.

The first commit prevents the input getting piped to the Sends if the Mix-Button is turned off. From my point of view it does not make any sense to apply an effect to a signal you dont hear at the moment.

The second commit applys the input volume fader also to the recordings, so you can adjust the volume of the recorded clips.

These are not so big changes, i did some testing and everything should work. So this should be ready for merging.

coderkun commented 6 years ago

The second commit applys the input volume fader also to the recordings, so you can adjust the volume of the recorded clips.

Does this mean that the volume is applied before the data is saved so that each loop records the volume?

georgkrause commented 6 years ago

Well, you have two input volume controls: the vertical fader and the knob above the Mix-Button (I call it monitor volume).

The vertical fader is applied BEFORE the recording of the clips, this is something like the input gain. The monitor volume is applied AFTER the recording, so this simply adjusts how loud you here the input.

Please note, the vertical fader is able to aplify the volume, while the monitor knob can only reduce the volume.

At the moment there is no way to control the volume of the recording with Luppp, you could only adjust the volume somewhere before the master inputs.

coderkun commented 6 years ago

The vertical fader is applied BEFORE the recording of the clips, this is something like the input gain.

Does this mean that if the fader is at 0, that the recorded data will be 0, too? I just want to get clear that the volume faders should not alter the recorded audio data but always be applied as a post-fader.

georgkrause commented 6 years ago

Well, i need to correct myself: I was talking about horizontal fader in the input section at the top right corner. The faders of the tracks wont be changed by this...

coderkun commented 6 years ago

I understand now, thanks for the explanation and sorry for the confusion ;)

georgkrause commented 6 years ago

Please dont merge, there is a bug

georgkrause commented 6 years ago

The bug should be fixed, i did some testing and this should be ready to merge.