openETCS / modeling

WP3 Top Level Project: to cover all tasks related with modeling
31 stars 42 forks source link

Track User Story 14: BG 903 misplaced: raises linkedBGMissed error #971

Closed UweSteinkeFromSiemens closed 8 years ago

UweSteinkeFromSiemens commented 8 years ago

BG 903 is reported as missed. When this error flag is raised, the observations are:

Due to 9735 < 9750, the train left BG903s expectation window without detecting it on the track.

The location of BG 903 has to be corrected.

UweSteinkeFromSiemens commented 8 years ago

An alternative eventuality for the observed symptom may be caused, if the test environment / test track simulation is only loosely coupled with the EVC and the BG detection and the odometry is arbitrary slipping around.

@jokaICS : Does the test environment with simctrl and TCP/IP preserve the clock synchronism between the test environment and the EVC model?

jokaICS commented 8 years ago

The test track runs within the EVC sim, so there is no delay for triggered balise telegrams/ radio messages due to TCP/IP (there is of course a small delay in the visualization of radio/balise messages on the SimCtrl UI).

A question regarding linking information (P005): the distance for the first announced BG is the distance from its predecessor (and not the distance from the current train position), correct? Probably a stupid question, but when I started designing the test track it was not obvious from the SRS (for me, at least).

UweSteinkeFromSiemens commented 8 years ago

The distance for the first announced BG refers to the just overpassed BG (if announced via BG) or to the LRBG (if announced via radio).

jokaICS commented 8 years ago

OK, but then the announcement of BG903 in the "Test Track" test.trk should be correct: image

15m (position of BG902) + 25m (d_link(0)) is 40m (position of BG903).

UweSteinkeFromSiemens commented 8 years ago

Further analysis of another test run, when the linkedBGMissed is raised :

1 clock cycle before the error flag is raised:

In the same cycle, when the error flag is raised:

In summary, the combination of overpassing, shrinking out of the expectation window and housekeeping in the same cycle causes the effect.

The observations need to be verified deeply before the bug can be fixed.

UweSteinkeFromSiemens commented 8 years ago

Fix provided with commit 13a58f391a1a610e4c14565b165215fe1cb907ef.

UweSteinkeFromSiemens commented 8 years ago

If BG 903 is not being missed any more, this issue can be closed. @BerndHekele, @Farhangi : feedback would be useful.

BerndHekele commented 8 years ago

Tested succeffully