Calculate Train Position: Verification

UweSteinkeFromSiemens commented 10 years ago

The calculation of location principles, train position and train orientation is specified in subset 026, chapt. 3.6. This function is central for the train operation and part of the first goal of WP 3 as defined in https://github.com/openETCS/SRS-Analysis/issues/9.

The determination of the train position is based upon balise groups detected while traveling and odometry information. Therefore, the locations of balise groups passed by the train and announced by linking information have to be computed by using odometry information. Then, if the locations of the balise groups are known, the current train position can be calculated related to the balise groups.

This is, what the function block CalculateTrainPosition to be verified, does. The verification object is made up of the following parts (see https://github.com/openETCS/SRS-Analysis/issues/34 and https://github.com/openETCS/SRS-Analysis/issues/35) :

A SysML model defining the functions inputs and outputs https://github.com/openETCS/modeling/tree/master/model/sysml/WP3-Initial-Architecture/ManageLocationRelatedInformation/ManageTrainPosition/CalculateTrainPosition
The calculation algorithms derived from the requirements and specified in https://github.com/openETCS/SRS-Analysis/blob/master/System%20Analysis/WorkingRepository/Group4/SUBSET_26_3-6/DetermineTrainLocationProcedures.docx
A scenario analysis and calculation method specified in "Train Position and Locations.odt" from @JanWelvaarts
A library of basic location calculation functions in https://github.com/openETCS/modeling/blob/master/model/Scade/System/ObuFunctions/ManageLocationRelatedInformation/TrainPosition/BasicLocationFunctions/
An implementation of "CalculateTrainPosition" in https://github.com/openETCS/modeling/tree/master/model/Scade/System/ObuFunctions/ManageLocationRelatedInformation/TrainPosition/CalculateTrainPosition

Although currently not all artefacts of CalculateTrainPosition are covered completely (see https://github.com/openETCS/SRS-Analysis/issues/35), WP 4 is asked for concurrent verification (see #177).

Fyi: @BerndHekele , @JanWelvaarts, @VNuhaan, @vgontier, @janWelte , @MarcBehrens , @faustco , @MariellePetitDoche

MarcBehrens commented 10 years ago

Grooming on the individual issues at the 12.06.2014 in Munich

[ ] Train Position and Locations.odt is planned to be modeled as a testmodel by @janWelte
[ ] A SysML model defining the functions inputs and outputs assigned to @vgontier
[ ] The calculation algorithms derived from the requirements
[ ] A library of basic location calculation functions
[ ] An implementation of "CalculateTrainPosition" in
[ ] Overall traceability

MarcBehrens commented 10 years ago

Grooming on Train Position Principles at the 15.7.2014 in Braunschweig

[ ] Do an additional verification on the "Train Position and Locations.odt" and "DetermineTrainLocationProcedures.docx" @cecilebraun

MarcBehrens commented 10 years ago

A Verification Model based on "Train Position and Locations.odt" has been written in LabView and uploaded thanks to @VNuhaan can be found here https://github.com/openETCS/SRS-Analysis/commit/edc8a3238e59ad4d2a2440f39e4c791cf6bbf7bd

UweSteinkeFromSiemens commented 10 years ago

Result from the 2014-07-15 meeting in Braunschweig:

It would be very helpful, if we would combine our verification activities:

[ ] TU Braunschweig: Specification of differences between different calculations and resulting implementations in relation to Subset 26 specifications; Coordination of verification activities
[ ] University Bremen: Check documents with focus of how test case can be implemented to run them on Uwe’s SCADE model using RT Tester
[ ] DLR: Check documents concerning possible integration of DLR Test facilities and existing test scenarios

MariellePetitDoche commented 10 years ago

FYI on going activities at Systerel:

[ ] Safety analysis (in a classical way) to extract safety properties
[ ] Verification of these properties on the Scade models by Systerel Smart Solver (SAT technologies)

MarcBehrens commented 10 years ago

@BerndGonska is doing a verification of the concept of train positioning coming from the specification verifying the approach focused on the confidence interval.

Approach 1 from @UweSteinkeFromSiemens: https://github.com/openETCS/SRS-Analysis/blob/master/System%20Analysis/WorkingRepository/Group4/SUBSET_26_3-6/DetermineTrainLocationProcedures.docx
Approach 2 from @JanWelvaarts: Contained within the Zip file https://github.com/openETCS/SRS-Analysis/commit/edc8a3238e59ad4d2a2440f39e4c791cf6bbf7bd

@BerndHekele: Do you have an update of the Approach 2 file?

KarstenFalk commented 10 years ago

Review session 20.08.2014:

update from @janWelte : comparisson of pure textual docs finished. short written report in preparation. probably finished 27th of august. only minor conclusions more in depth look into implementation needed. no date stated.
@vgontier any updates on SysML model defining the functions inputs and outputs ?
@cecilebraun any updates on additional verification on the "Train Position and Locations.odt" and "DetermineTrainLocationProcedures.docx" ?
@BerndGonska are there results on verification of the concept of train positioning that can be uploaded to DLR user story?

vgontier commented 10 years ago

Hello No updates on SysML model at this date. Best regards

Véronique Gontier - ALL4TEC 2 / 12 rue du Chemin des Femmes - 91300 Massy 06.38.81.79.14 - veronique.gontier@all4tec.net www.all4tec.net

Le 20/08/2014 10:56, Karsten Falk a écrit :

Review session 20.08.2014:

update from @janWelte https://github.com/janWelte : comparisson of pure textual docs finished. short written report in preparation. probably finished 27th of august. only minor conclusions more in depth look into implementation needed. no date stated.

@vgontier https://github.com/vgontier any updates on SysML model defining the functions inputs and outputs ?

@cecilebraun https://github.com/cecilebraun any updates on additional verification on the "Train Position and Locations.odt" and "DetermineTrainLocationProcedures.docx" ?

@BerndGonska https://github.com/BerndGonska are there results on verification of the concept of train positioning that can be uploaded to DLR user story?

— Reply to this email directly or view it on GitHub https://github.com/openETCS/validation/issues/227#issuecomment-52750197.

cecilebraun commented 10 years ago

The review of the document from our side will not be available before mid-September.

Regards

janWelte commented 10 years ago

Review session 27.08.2014

new version by @UweSteinkeFromSiemens today - SCADE model Train Position (https://github.com/openETCS/modeling/commit/0dd6113645faac76d4b81b74679d2c3612facdc3)
No change of external interfaces
Cleanup of the internal model structure
BGs sorted by their location
Inaccuracies optimization at the current train position
CPU work load reduced

function is finished from WP 3 modelling perspective! WP 4 work needed!

BerndGonska commented 10 years ago

Hello,

i looked into the two train position documents and found some possible SRS-deviations in both.

The detailed review documents with SRS references will be ready next Monday. In addition, a short document that shows in formulas the basic SRS-variables of the train positioning system with references to the SRS. It also contains examples with detailed values.

janWelte commented 10 years ago

Dear Bernd,

thank you, this sound great. If this work is finished please link the documents here and change the status. If you exspect tasks to be performed (e.g. review or corrections of the model) please indicate this in new issues and relate them to this task.

UweSteinkeFromSiemens commented 10 years ago

A description of the model functions and structure is available in https://github.com/openETCS/modeling/blob/master/openETCS%20ArchitectureAndDesign/FirstIteration/openETCSArchitectureAndDesignSpecification.pdf
The model and the model documentation has been updated, see https://github.com/openETCS/modeling/tree/master/model/Scade/System/ObuFunctions/ManageLocationRelatedInformation/TrainPosition/CalculateTrainPosition/GeneratedDocuments

KarstenFalk commented 10 years ago

Review on 03. Sept 2014:

SysML model defining the functions inputs and outputs assigned to @vgontier is waiting in input from the Brussels workshop next week
[x] @BerndGonska is planning to upload his review until end of this week 05. Sept.

MarcBehrens commented 9 years ago

The verification closing session for the design phase related to this topic is now terminated to the 28th to 29th of October 2014 and takes place in Brunswick. If you plan to contribute to the contents you are kindly requested to participate to the upcomming WP4 telcos the 17th 10h30 or the 22nd of October. Participationlist is handeled via thefollowing doodle: http://doodle.com/47vpuyv993rp5ske

UweSteinkeFromSiemens commented 9 years ago

The content of https://github.com/openETCS/SRS-Analysis/blob/master/System%20Analysis/WorkingRepository/Group4/SUBSET_26_3-6/DetermineTrainLocationProcedures.docx has been condensed to what was used in the SCADE implementation of the CalculateTrainPosition function.

MarcBehrens commented 9 years ago

please read in preparation of the verification closing session the updated document by Uwe, which replaces the old design document: https://github.com/openETCS/SRS-Analysis/blob/master/System%20Analysis/WorkingRepository/Group4/SUBSET_26_3-6/DetermineTrainLocationProcedures.docx?raw=true

MarcBehrens commented 9 years ago

please read in preparation of the verification closing session the document "Train Position and Locations.odt" inside the following ZIP file: https://github.com/openETCS/SRS-Analysis/commit/edc8a3238e59ad4d2a2440f39e4c791cf6bbf7bd

UweSteinkeFromSiemens commented 9 years ago

A detailed test scenario description and visualization for CalculateTrainPosition is available at https://github.com/openETCS/modeling/blob/master/model/Scade/System/ObuFunctions/ManageLocationRelatedInformation/TrainPosition/CalculateTrainPosition/outputs/Train_BGs_Location_3_linked_2_unlinkedBGs.pdf.

UweSteinkeFromSiemens commented 9 years ago

Test results procuduced by the SCADE model executing the scenarios 1, 7 und 9 defined by @VNuhaan are available at https://github.com/openETCS/modeling/tree/master/model/Scade/System/ObuFunctions/ManageLocationRelatedInformation/TrainPosition/CalculateTrainPosition/outputs/Vincents_Scenarios.

MarcBehrens commented 9 years ago

Grooming of Verification Closing Report: