search

openMF / android-client

An android client for the MifosX platform
https://openmf.github.io/mobileapps.github.io/
Mozilla Public License 2.0
196 stars 576 forks source link

App crashes on leaving the "Amount Disbursed" field in the Disburse Loan Dialog fragment empty #662

Closed AbhilashG97 closed 7 years ago

AbhilashG97 commented 7 years ago

Summary:

App crashes on leaving the "Amount Disbursed" field in the Disburse Loan Dialog fragment empty. A suitable error message stating that the field cannot be empty would be a better response to the issue. The logs for this issue can found here.

Steps to reproduce:

Step 1) Open the app. Step 2) Tap on the Clients fragment from the navigation drawer. Step 3) Select a Client. Step 4) Tap on Loan Accounts and select an account which can disburse a loan. Step 5) Tap on Disburse Loan. Step 6) Leave the "Amount Disbursed" field empty. Step 6) Tap on Submit.

Expected behavior:

The app shouldn't crash and should a display a suitable error message.

Observed behavior:

The app crashes on leaving the "Amount Disbursed" field empty.

Device and Android version:

Device : Motorola Moto G 1st Generation [XT1033] [Falcon] ROM : CyanogenMod 13.0 Snapshot build

GIF:

videotogif_2017 04 06_10 36 18

AbhilashG97 commented 7 years ago

I would like to work on this issue.

AbhilashG97 commented 7 years ago

I have made the required changes, please review my pull request and kindly let me know if I have to make any further changes. Pull request - https://github.com/openMF/android-client/pull/665