search

openMF / mobile-wallet

A reference implementation of Mifos platform wallet and payment capabilities
https://openmf.github.io/mobileapps.github.io/
229 stars 427 forks source link

App crashes in a particular situation #477

Open shiv07tiwari opened 5 years ago

shiv07tiwari commented 5 years ago

Summary:

When the user opens KYC and presses back before loading is completed, then the app crashes.

videotogif_2019 03 12_21 27 44

shaliniv16 commented 5 years ago

@shiv07tiwari please refer to #213 and #200

shiv07tiwari commented 5 years ago

@shaliniv16 I think you misunderstood the issue. Its not about bringing the user to particular activity, but the app crashes which has to be handled.

shaliniv16 commented 5 years ago

@shiv07tiwari Can you please explain how I could produce the issue again?

shiv07tiwari commented 5 years ago

@shaliniv16 -

  1. Open KYC section
  2. Press back button before the loading is done
  3. Again press back button
shaliniv16 commented 5 years ago

@shiv07tiwari You have simply mentioned the obvious steps to exit the app. You will reach home activity if you press the back button before the loading is done. Pressing the back button again will allow the user to exit the app. This is not how the app will crash. Have I misinterpreted the steps mentioned?

shiv07tiwari commented 5 years ago

Pressing on back button keep the user in KYC activity, and then the back button takes him to the home activity.

RajaVamsi11 commented 5 years ago

@shiv07tiwari I tried the above mentioned steps in dev branch but I did not find any crash on my mobile. @shaliniv16 Can you try the steps and tell if the app was crashing on your device.

mrudultora commented 3 years ago

@shiv07tiwari Sir you are right. I encountered the same issue as by the steps you told. It is giving a nullpointerexception. Attaching a image of Logcat for more info. Sir, I want to work on this issue. May I work on it? Crashed

mrudultora commented 3 years ago

@shaliniv16 @RajaVamsi11 When you tried it didnt't crashed (but exited from the app) because the KYCDescriptionFragment brings back you to the HomeFragment immediately due to onError callback in KYCDescriptionPresenter.java . I was able to reproduce it once after trying 7-8 times.