Stop "CPU registers changes" modal window from showing up twice, thri…

openMSX / debugger

31 stars 15 forks source link

Stop "CPU registers changes" modal window from showing up twice, thri… #124

Closed pvmm closed 2 years ago

pvmm commented 2 years ago

…ce and more

How to replicate this error:

change a CPU register in CPURegsView;
Press ESCAPE or change focus to display modal "CPU registers changes" window;
Change focus to and from app again;
lostFocus event will be triggered showing up the modal window again;
Keep changing focus in and out of the debugger to display a new modal window;

m9710797 commented 2 years ago

Thanks!

I do wonder how this 'static bool isVisible' will interact with the 'blendersplit' branch David is working on. Because (as far as I understand) there it will be possible to have multiple CPURegsViewer instances active. I assume you still only want one modal dialog in that case?

pvmm commented 2 years ago

Well, yes. If it is a modal dialog, the main window will not receive any input, even from another widget of the same type. So it shouldn't be possible to create another modal dialog to begin with.