Closed UlrikeS91 closed 2 years ago
@UlrikeS91 I agree to removing "microscopy" but maybe next year (if this is already in use in EBRAINS) I don't want to do another mapping right now for migration. But I will check how far this term is in use.
The rest I leave to @tgbugs
@UlrikeS91 @lzehl, "microscopy" is not in use so can be removed
@MaaikevS would you prepare the PR for the removal of microscopy? I will delete it afterwards from the EBRAINS KG
@lzehl Sure I can make a PR. Do you mean, remove the file? Or are there some intricate details I am not aware of?
@MaaikevS yes. just remove the jsonld file. the rest has to happen in the EBRAINS KG.
Done! See PR #145
Result of discussion with @tgbugs :
Let's add definitions to see what we might want to merge, but I think besides the widefield fluorescence microscopy & epifluorescent microscopy these can be all considered as different techniques
Thanks to everybody for all the discussion (online and offline) and the PRs to make first fixes! To see where we are with this issue, I'd like to sumnmarize and identify the parts that are still open.
During the discussion, we pretty much agreed that all of the listed microscopy techniques will remain (except for microscopy which is captured as an experimental approach in openMINDS).
I've copied in the list of techniques from above here again with comments about their status:
(previously) existing technique | definition added? | other notes |
---|---|---|
Microscopy | - | deleted |
Brightfield microscopy | yes | |
Confocal microscopy | yes | |
Electron microscopy | yes | |
Fluorescence microscopy | yes | |
Light microscopy | yes | |
Light Sheet Fluorescence microscopy | yes | |
Polarized Light microscopy | yes | |
Widefield microscopy | yes | |
Electron tomography | yes | wasn't in my original list |
Dual View Inverted Selective Plane Illumination microscopy | no | |
Epifluorescent microscopy | no | this is the same as widefield fluorescence microscopy, delete one and add other as synonym |
Focused Ion Beam Scanning Electron microscopy | no | |
Scanning Electron microscopy | no | |
Serial Section Transmission Electron microscopy | no | |
Transmission Electron microscopy | had one already | |
Two-Photon Excitation Fluorescence microscopy | had one already | |
Widefield Fluorescence microscopy | had one already | this is the same as epifluorescence microscopy, delete one and add other as synonym |
This means that the ones without a definition should get one and we should also have a look at the ones that already had a definition again just to check that we are happy with them. All of these should also get ontology IDs if possible, so we could fix those in parallel when adding the definitions and/or check the existing definitions.
Here the questions when I opened the issue:
So, in short, my questions are:
- Add "confocal light-sheet microscopy" - yes or no?
- Remove "microscopy" (actual not a question)
- "widefield fluorescence microscopy" same as "epifluorescent microscopy" - yes or no?
- If 3. is answers with no, rename "epifluorescent microscopy" to "epifluorescence microscopy" to be consistent with the other fluorescence techniques?
To-Do:
I think this is it ☺️ Once we fixed the to-do list items, we should be able to close this ticket! I'll work on this today.
@ingrre asked if we could add "confocal light-sheet microscopy" and I think that it would make sense to do so. @tgbugs I checked the method ontology but couldn't find it there. Would it make sense to add it?
Additionally, I'm kind of wondering where we draw the line for the microscopy related terms? Below is a list of all microscopy term that we added so far:
The easy one first: "microscopy" needs to be removed. This is a duplication since it exists as an experimental approach (which obviously makes most sense anyway).
Then, I think widefield fluorescence microscopy & epifluorescent microscopy might be synonym (see here: https://oni.bio/nanoimager/super-resolution-microscopy/epifluorescence-microscopy/).
So, in short, my questions are:
@lzehl feel free to comment as well :)