search

openPMD / openPMD-visit-plugin

:telescope: Plugin allowing VisIt to read openPMD files
Other
9 stars 4 forks source link

Updated the Mac OSX installation instructions #11

Closed syoffe closed 6 years ago

syoffe commented 6 years ago

I have updated the installation instructions for Mac OSX based on my experience installing the plugin on MacOS High Sierra. I had to use VisIt version 2.11, and after running xml2cmake I had to add SET(CMAKE_MACOSX_RPATH 1) to the CMakeLists.txt file.

I also had to remove (pointer)>0 comparisons from OpenPMDClasses/PMDField.C which prevented compilation.

Finally, I wasn't sure which branch to use for this PR. The CONTRIBUTING.md file says dev, but there is no dev branch, and the develop branch hasn't been updated as recently as master. Perhaps this can be updated/clarified in the documentation.

xxirii commented 6 years ago

Thank you Sam for your contribution,

In principle, develop should be used until new changes are checked and confirmed. Here, develop is still behind for some reasons. I will fix it. Thanks again for pointing out these mistakes.

Have you managed to visualize data correctly?

syoffe commented 6 years ago

Thanks for the information, @xxirii

Yeah, I have managed to visualise FBPIC data in VisIt using the plugin! The axes seem to be a little bit confused but it's not a big deal. It seems to think that the z data (longitudinal axis) is the x axis, which is not difficult to work around once you know.

xxirii commented 6 years ago

@syoffe Thank you for your feedbacks.

Axis labels is a long story. The plugin was first developed for WARP that considers "z" as the first axis. Some codes prefer "x". The problem is that the axis labels in OpenPMD files are not always in the right order so I had to make a choice but I admit that this is another point to be addressed and improved.