search

openSUSE / brp-check-suse

Build root policy check scripts
GNU General Public License v2.0
5 stars 21 forks source link

Add NO_BRP_AR as a way how to skip ar. #16

Closed marxin closed 5 years ago

marxin commented 5 years ago

It would be useful for Go packages: https://github.com/golang/go/issues/17890

marxin commented 5 years ago

@sleep-walker

bmwiedemann commented 5 years ago

So how sure are we that objcopy screws go's extra info in .a files? I hope, objcopy will then still be called for non-go packages. Then I'm fine with it.

bmwiedemann commented 5 years ago

one thing: please add some more detail about "Why" in the commit message. Links to bugtrackers can go stale some day and finding the relevant part in it is also not always easy.

marxin commented 5 years ago

So how sure are we that objcopy screws go's extra info in .a files?

Very sure.

I hope, objcopy will then still be called for non-go packages. Then I'm fine with it.

Yes, that's our intention.

marxin commented 5 years ago

one thing: please add some more detail about "Why" in the commit message. Links to bugtrackers can go stale some day and finding the relevant part in it is also not always easy.

Done.

marxin commented 5 years ago

Can please anybody merge the PR now?