search

openSUSE / brp-check-suse

Build root policy check scripts
GNU General Public License v2.0
5 stars 21 forks source link

redefine Science and Education to comply with guidelines #18

Closed bnavigator closed 5 years ago

bnavigator commented 5 years ago

if you don't want to discard the whole test (#14), at least fix the categories according to the guidelines (https://en.opensuse.org/openSUSE:Packaging_desktop_menu_categories). Fixes the specific mentioned categories in #4

Other categories than Science and Education possibly still need to be updated to the current guidelines.

coolo commented 5 years ago

I can merge this (as there doesn't seem to be maintainers :cry: ), but I can't predict what it causes. So are you willing to monitor the fallout?

bnavigator commented 5 years ago

Yes I can watch the opensuse bugzilla and GitHub issues here regarding the Science and Engineering desktop categories.

coolo commented 5 years ago

submitted to Base:System

krop commented 5 years ago

The SR was accepted and we're seeing build failures in KDE packages. eg:

[ 135s] ERROR: No sufficient Category definition "Qt;KDE;Education;X-KDE-Edu-Misc;X-KDE-Edu-Teaching;"

As X-KDE-Edu-Teaching is still recognized, that leaves X-KDE-Edu-Misc which is valid:

Categories not in this document must be prefixed by the string "X-" indicating that they are extensions. Categories are case-sensitive.

(https://standards.freedesktop.org/menu-spec/latest/ar01s03.html)

bnavigator commented 5 years ago

No, it fails because if X-KDE-Edu-Teaching not being recognized by the macro. See #27 for a fix

krop commented 5 years ago

Well, we're seeing issues in other areas now as well. See https://github.com/openSUSE/brp-check-suse/issues/26