openSUSE / get-o-o

Website that provides detailed information about openSUSE distributions
https://get.opensuse.org
Creative Commons Attribution Share Alike 4.0 International
61 stars 46 forks source link

gaming section text added on tumbleweed page #180

Closed sharabhh closed 10 months ago

sharabhh commented 10 months ago

Fixed #5 Added some information about gaming on Tumbleweed.

Before: image

After: image

hellcp commented 10 months ago

Hm, this PR contains no changes that are shown in the screenshot and just changes the dependencies instead

hellcp commented 10 months ago

Sorry, I assumed you figured out how to do this properly, this is where the features are defined: https://github.com/openSUSE/get-o-o/blob/main/_data/locales/en.yml#L357, you just need to modify this file

sharabhh commented 10 months ago

Sorry, I assumed you figured out how to do this properly, this is where the features are defined: https://github.com/openSUSE/get-o-o/blob/main/_data/locales/en.yml#L357, you just need to modify this file

ohh okay I'll modify this one

sharabhh commented 10 months ago

image

sharabhh commented 10 months ago

@hellcp will this work? or should I create a separate pull request with only this file edited. Right now I think my previous commits are also showing up.

hellcp commented 10 months ago

They are, you can use git rebase -i HEAD~3, and mark the commits in the file that shows up appropriately based on the description in that file and then git log to verify you only have the commits you have on the branch and then git push --force to push the commits you want to this PR

sharabhh commented 10 months ago

@hellcp I changed it to remix icons

hellcp commented 10 months ago

The Gemfile.lock manifested in this, so try removing it from the commit