openSUSE / obs-service-replace_using_package_version

An OBS service to replace a regex with some package version available in the build time repositories
GNU General Public License v3.0
4 stars 12 forks source link

new patch_update and offset parameters #3

Closed denisok closed 5 years ago

denisok commented 5 years ago

Some of the packages could use source control offset to better identify version for their packages. This could look like as "3.14.1+git5.g9265358", it is described in Package naming guidelines for openSUSE.

Other packages could use fourth digit as identification, that could be anything, for example "ceph" package uses that for the same source code offset (maybe incorrectly but possibility is there).

This patch add those 2 new parameters. They could be used as unique tags for the containers as "+" character is not allowed in the tag name for the docker container.

denisok commented 5 years ago

Thanks much for the contribution. Just some small comments and little changes to be done.

@denisok where do you need it? I mean in which code base? I am wondering if a bugzilla ticket might be required for updating

I need it for the Ceph and Rook container builds. I need to have unique tag and version numbers that I could assign for the container tags and sed it into the yaml mainfests. Ceph and Rook: https://build.opensuse.org/package/show/filesystems:ceph/ceph https://build.opensuse.org/package/show/filesystems:ceph/rook they have these versions types:

I could open bugzilla if needed. I would like to get this integrated into the OBS and IBS.

davidcassany commented 5 years ago

I could open bugzilla if needed. I would like to get this integrated into the OBS and IBS.

Yes I was mostly asking if you need it in SLE15 or so. If no specific needs I will just merge and package it to Factory.