openactive / implementation-tracker

Activation Issue Tracker for OpenActive Implementations
1 stars 2 forks source link

RPDE implementation issue #175

Closed nickevansuk closed 6 years ago

nickevansuk commented 6 years ago

Paging does not seem to be correctly implemented: id and modified values of the last item in the page do not match those in the next URL. The last item in each page must be used to generate the next URL.

One symptom of this is that the following page erroneously points to itself: https://api.englandnetball.co.uk/api/openactive/sessions?afterId=77708&afterTimestamp=1536663982

nickevansuk commented 6 years ago

Also note the page size should be 500 rather than 20.

nickevansuk commented 6 years ago

Please use the validator at https://validator.openactive.io/rpde with the following seed URL to see the issue:

Also please see our handy video to explain why this is problematic: https://developer.openactive.io/publishing-data/data-feeds/how-a-data-feed-works

daniel-somersault commented 6 years ago

@nickevansuk it seems to be passing now on the validator

nickevansuk commented 6 years ago

@daniel-somersault seems to still be failing for me:

https://validator.openactive.io/rpde?url=https://api.englandnetball.co.uk/api/openactive/sessions?afterId=77708&afterTimestamp=1536663982

daniel-somersault commented 6 years ago

@nickevansuk I'm a bit confused, if I run the validator without any parameters set everything passes?

nickevansuk commented 6 years ago

The validator only checks 20 pages of the feed from the start point provided. Starting from a point further into the feed sometimes reveals issues not seen at the beginning of the feed.

Suggest checking the video and query on this page to ensure your implementation is correct:

https://developer.openactive.io/publishing-data/data-feeds/how-a-data-feed-works

daniel-somersault commented 6 years ago

@nickevansuk hopefully we have fixed the problem now. Passing against that now.

nickevansuk commented 6 years ago

Looks great!