search

openactive / models-php

PHP Models for the OpenActive Opportunity and Booking Specifications
MIT License
6 stars 8 forks source link

Update git clone method in the readme #108

Closed drinkynet closed 1 year ago

drinkynet commented 1 year ago

A bunch of fixes for the OrdersFeedModifier tests

nathansalter commented 1 year ago

This appears to only change a single file, are you sure this is what's expected?

drinkynet commented 1 year ago

Yes, the 10 commits from a year ago all change the same file. Found them sat in my fork when I came to add the new modifier.

nathansalter commented 1 year ago

I'm not sure what the purpose of this PR is, the title implies that it's fixing something but the code just changes a line in the Readme?

drinkynet commented 1 year ago

It contains a bunch of fixes to the OrdersFeedModifier I made last year which I forgot to PR then.

The readme change has become attached to this PR possibly because it was made on the same branch.

drinkynet commented 1 year ago

I see what you mean from the files changed tab. I'm not sure what's going on then...

drinkynet commented 1 year ago

Perhaps I should change the title of the PR to update git clone method in the readme