search

openactive / models-php

PHP Models for the OpenActive Opportunity and Booking Specifications
MIT License
6 stars 8 forks source link

Add PHP8 Support #65

Closed nathansalter closed 3 years ago

nathansalter commented 3 years ago

With the latest release of PHP 8 we should add support for this so that people can use this library in more recent versions. I have run the tests and they complete successfully. Also dropped support for PHP 5 as the active user-base for 5.6 has dropped to <3%.

nickevansuk commented 3 years ago

We need to check but I think there are folks running 5.6 that use this library. Although overall use may be <3% our sector is notorious for underinvestment in updating to the latest tech. Is there a way we can still support 5.6 while still supporting PHP 8? Also worth noting CI should be updated to test PHP 8 too.

nathansalter commented 3 years ago

Is there a way we can still support 5.6 while still supporting PHP 8?

Oh yes definitely, we should be able to span across all three major versions.

Also worth noting CI should be updated to test PHP 8 too.

I don't have access to Travis to be able to make this change, do you know who would?

nickevansuk commented 3 years ago

Great, sounds good!

Travis config is here: https://github.com/openactive/models-php/blob/84b7ae4c04b9ab25edd1635387bba06e740a90c6/.travis.yml#L3-L4

nathansalter commented 3 years ago

Ah missed it because it's a dotfile /facepalm