openactive / openactive-test-suite

Test suite for OpenActive implementations
MIT License
2 stars 9 forks source link

Read Feed URLs from dataset site, and ensure appropriate error is thrown and displayed if dataset site is invalid #59

Closed henryaddison closed 4 years ago

henryaddison commented 4 years ago

https://github.com/openactive/data-models/blob/master/versions/2.x/meta.json#L9

Read from dataset site in order to receive URL configuration of feeds, using the “parent” attribute of https://github.com/openactive/data-models/blob/master/versions/2.x/meta.json#L9 to automatically infer “Opportunity” and “OpportunityParent”

What is an OpportunityParent? In fact what is an Opportunity? See the 'Bookable Objects in the Model' diagram on p. 3 here: https://docs.google.com/document/d/1mo_N1xa0H9D4uVEz3m8kyCPAAXcSEjwpEiv995hDxQs/edit#. Opportunities are the bottom row; their parents are the top (in humanspeak, an Opportunity is an 'opportunity to exercise')

ylt commented 4 years ago

What purpose does the meta.json serve here? From the task description, I'd expect it to be purely to

What extra does the meta.json add here?

nickevansuk commented 4 years ago

This has been implemented