openaddresses / machine

Scripts for running OpenAddresses on a complete data set and publishing the results.
http://results.openaddresses.io/
ISC License
97 stars 36 forks source link

Kosovo is not coloured green on the map, missing from coverage #700

Closed stefanb closed 6 years ago

stefanb commented 6 years ago

After https://github.com/openaddresses/openaddresses/pull/3866 was merged imports seem to be running fine: http://results.openaddresses.io/sources/xk/countrywide but

Perhaps there is some misalignment in the ISO country code XK vs KV ?

The map on the main page https://openaddresses.io/ is showing the addresses nicely.

Is machine respecting strictly just ISO-assigned 2-letter country codes and is not knowing either of those?

migurski commented 6 years ago

I think I see the problem: our Natural Earth countries dataset does not include an ISO 2-letter code for Kosovo. I’ll fix it in our copy. /cc @nvkelso

stefanb commented 6 years ago

It would be nice to either:

migurski commented 6 years ago

Checking for a valid code shouldn’t be too difficult. In this case you’d have received a warning that we don’t know “XK”.

stefanb commented 6 years ago

In the coverage table on http://results.openaddresses.io/coverage/world/ there is still no sign of Kosovo.

Validating the code would make sense only if there is no geometry defined in the source json, so that machine make sure that it understands the coverage.