search

openaddresses / machine

Scripts for running OpenAddresses on a complete data set and publishing the results.
http://results.openaddresses.io/
ISC License
97 stars 36 forks source link

Toronto data missing city name #709

Closed Valachio closed 5 years ago

Valachio commented 5 years ago

First of all. This project is a godsend. Thank you for your great work.

I'm referring to this dataset - http://results.openaddresses.io/sources/ca/on/city_of_toronto

The dataset is missing the district names (Scarborough, Etobicoke, North York, York, and East York)

Toronto is technically one large municipality after an amalgamation in 1998, but people still refer to the former districts by their names. Partly because the amalgamation created duplicate addresses.

E.g. There is a 6 Church Street, North York and 6 Church Street, Toronto

The address data provided by Open Data Toronto has the district name of each address. I believe it should be available through the source you guys download the data through as well.

iandees commented 5 years ago

Future data-related tickets like this should go in openaddresses, not this repo.

iandees commented 5 years ago

Thanks for pointing this out! I made https://github.com/openaddresses/openaddresses/pull/4294 to add the municipality name in the city column of the output here.

Valachio commented 5 years ago

@iandees My fault. Thank you for responding quickly

We will try to help with Canadian addresses wherever we can (we are building a real estate app for Canada). Keep this project alive and strong! It's one of its kind and incredibly valuable to people.

migurski commented 5 years ago

Thanks for saying so, @Valachio!

I looked at the city name in the data, and the most common value is “former Toronto”. Does that sound right to you?

    Most common values:    former Toronto (157401x)
                           Scarborough (123906x)
                           North York (114222x)
                           Etobicoke (73521x)
                           York (32476x)
Valachio commented 5 years ago

@migurski You can safely change "former Toronto" to just "Toronto". Or keep it for maximum clarity, since it is fairly straightforward to clean.

Former Toronto in this case refers to the original part of Toronto before amalgamation in 1998. The locals do not refer to this part as former Toronto or old Toronto - we just call it Toronto.

migurski commented 5 years ago

Thanks for the explanation. I think we should leave this alone so we’re not special-casing places, but I appreciate the local history check.