search

openai / deeptype

Code for the paper "DeepType: Multilingual Entity Linking by Neural Type System Evolution"
https://arxiv.org/abs/1802.01021
Other
649 stars 146 forks source link

blacklist in argument triggers error #13

Closed galtay closed 6 years ago

galtay commented 6 years ago

from README file,

python extraction/project_graph.py ${DATA_DIR}wikidata/ extraction/blacklist.json extraction/classifiers/type_classifier.py  --export_classification ${CLASSIFICATION_DIR}

having "extraction/blacklist.json" in the command makes the main function error out here (https://github.com/openai/deeptype/blob/master/extraction/project_graph.py#L87). It looks like the blacklist is read no matter what here (https://github.com/openai/deeptype/blob/master/extraction/project_graph.py#L101)

galtay commented 6 years ago

added fix to #12

karimvision commented 6 years ago

+1 i had this problem too, i changed the arguments manually to match those inside the file, i think i removed blacklist.json from the arguments when i ran this

JonathanRaiman commented 6 years ago

Yes. Readme used to manually specify location of the blacklist, while now it's always used (no real reason to have multiple blacklists. #12 is merged)