search

openalea / phenomenal

Phenomenal: An automatic open source library for 3D shoot architecture reconstruction and analysis for image-based plant phenotyping
https://phenomenal.readthedocs.io
Other
35 stars 17 forks source link

updating numpy + vtk functions #46

Closed AurelienBesnier closed 1 month ago

AurelienBesnier commented 1 month ago

Hi ! I updated some of the imports of vtk modules which were outdated and also made some updates of numpy functions to be compatible with 2.0 and 1.x.

For the compatibility with numpy 2.0 we still need to wait for the skan package to be updated.

Also with @christian34 we investigated the problems we had with the CI and they are now fixed.

pradal commented 1 month ago

Excellent. You introduce a new dependency : vtkmodule. Is it provided by vtk? Otherelse you have to add it to meta.yaml

AurelienBesnier commented 1 month ago

The vtkmodules is included in the vtk package. As per the vtk documentation:

The 'vtk.py' module is obsolete and is only provided for backwards compatibility. When you import vtk, this module actually provides you with the 'vtkmodules.all' module via some internal trickery:

>>> import vtk
>>> vtk.__name__
'vtkmodules.all'